Remove gmock dependency #663
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 9 9
Lines 3853 3853
=======================================
Hits 3051 3051
Misses 802 802 🚀 New features to boost your workflow:
|
mcbarton
force-pushed
the
Remove-the-need-for-gmock
branch
from
4fa0c87 to
7d6b496
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
|
Gtest and gmock are part of the testing infrastructure of Google. I don’t think we should remove gmock as I think we want to have it if in future we use the mocking infrastructure for writing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of changes, motivation and context for this PR.
We only use gmock for one quite simple test, so this PR rewrites that test to avoid the need for gmock, so we can remove it as a dependency.
Fixes # (issue)
Type of change
Please tick all options which are relevant.
Testing
Please describe the test(s) that you added and ran to verify your changes.
Checklist